Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove legacy machtigen context #4911

Merged

Conversation

sergei-maertens
Copy link
Member

Part of #3283

The shape of data that we store was badly documented, not in the least because we barely had any idea what kind of information we receive.

Since Open Forms 2.7.0 it has been fleshed out what the mandata context looks like, and properly implemented backed by a proposal for a standard which is implemented all the way to Open Zaak to try out.

This legacy context is now being removed in favour of the new way to track and expose the mandata context.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

The shape of data that we store was badly documented, not in the least
because we barely had any idea what kind of information we receive.

Since Open Forms 2.7.0 it has been fleshed out what the mandata context
looks like, and properly implemented backed by a proposal for a
standard which is implemented all the way to Open Zaak to try out.

This legacy context is now being removed in favour of the new way
to track and expose the mandata context.
@sergei-maertens sergei-maertens changed the title 💥 [#3283] Remove legacy machtigen context 💥 Remove legacy machtigen context Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (3a70208) to head (8f48703).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4911      +/-   ##
==========================================
- Coverage   96.57%   96.57%   -0.01%     
==========================================
  Files         757      757              
  Lines       25750    25746       -4     
  Branches     3383     3383              
==========================================
- Hits        24869    24865       -4     
  Misses        616      616              
  Partials      265      265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robinmolen robinmolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks nice!

There is a leftover translation in the django.po, maybe nice to remove that one :)

@sergei-maertens
Copy link
Member Author

Yeah looks nice!

There is a leftover translation in the django.po, maybe nice to remove that one :)

I'll handle it in #4934 !

@sergei-maertens sergei-maertens merged commit 486d9cb into master Dec 17, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the cleanup/3283-remove-legacy-machtigen-context branch December 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants